ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <pe...@apache.org>
Subject Re: cvs commit: jakarta-ant/proposal/myrmidon/src/testcases/org/apache/myrmidon/components/deployer DefaultDeployerTest.java TestConverter1.java TestType1.java
Date Sat, 02 Feb 2002 14:16:42 GMT
On Sat, 2 Feb 2002 23:51, adammurdoch@apache.org wrote:
>   /**
>    * A general-purpose type definition.
>    *
>    * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>    */
>   public class GeneralTypeDefinition
>       extends TypeDefinition
>   {
>       private String m_name;

vs

>   public abstract class TypeDefinition
>   {

Is there any need to separate out the above two classes? From the looks of 
things - no - but is there something else you have in mind?

>   /**
>    * A base class for tests for the default components.
>    *
>    * @author <a href="mailto:adammurdoch@apache.org">Adam Murdoch</a>
>    */
>   public class ComponentTestBase extends TestCase

Do you want to rename this to AbstractComponentTest because that fits in with 
the naming patterns of swing (which is consistent with the rest of the 
myrmidon codebase).

-- 
Cheers,

Pete

--------------------------------
My opinions may have changed, 
but not the fact that I am right
--------------------------------

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message