Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 21153 invoked from network); 31 Jan 2002 15:24:19 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 31 Jan 2002 15:24:19 -0000 Received: (qmail 21858 invoked by uid 97); 31 Jan 2002 15:23:51 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 21718 invoked by uid 97); 31 Jan 2002 15:23:50 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 21637 invoked from network); 31 Jan 2002 15:23:48 -0000 Message-ID: <86F21E9558CE6F429B2D0AEB9820F1B80142B618@S1001EXM01.macromedia.com> From: Brian Deitte To: "'Ant Developers List'" Subject: RE: [PATCH] zip/jar improvements * 2 Date: Thu, 31 Jan 2002 10:23:41 -0500 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="iso-8859-1" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Thanks for the comments Magesh. I'm tied up right now, but I'll try to get a new patch out with some of your suggestions within a week. Some reponses below... > Is it possible to make this configurable by letting > the user specify whether the file is to be added > or duplicated with the default option set to duplicated? > This would ensure backwards compatibility as well > as let the user take her pick. Sure, I can do this, but is there any case where people really want duplicate files within the same directory? I was surprised this was even possible! > In your code, I noticed that you have used // > to comment private variables. Use commenting style > recognized by javadoc instead. Please also provide > valid javadoc comments for all methods that > you introduce. I confess, I didn't comment as much as I should have for the amount of changes I made. I'll add some more. An unrhetorical question, though: do people javadoc private variables? I can change this, but I'm just curious, because I've never worked with a group that does this. Thanks again, Brian -- To unsubscribe, e-mail: For additional commands, e-mail: