Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 6866 invoked from network); 25 Jan 2002 16:11:01 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 25 Jan 2002 16:11:01 -0000 Received: (qmail 4526 invoked by uid 97); 25 Jan 2002 16:10:57 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 4510 invoked by uid 97); 25 Jan 2002 16:10:57 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 4499 invoked from network); 25 Jan 2002 16:10:56 -0000 Message-ID: <00db01c1a5ba$ded07cb0$270610ac@manu.com> From: "Magesh Umasankar" To: "Ant Developers List" References: <9B3E950CB293D411ADF4009027B0A4D202BA0B7B@maileu.imediation.com> Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/i18n Translate.java Date: Fri, 25 Jan 2002 11:10:55 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N From: "Stephane Bailliez" > It is not dramatic because it's a bean setter, but the I prefer > > public void setFile(File value) { > file = value; > } This is nice, but when you have multiple arguments, you would end up with value1, value2, etc, or fileValue, isOverwriteValue, etc? My guess is you would choose fileValue over value1. So, that makes it Value a suffix of the argument which is not very different from having 'a' as the prefix of an argument. > though my preferences goes to the > invalid-becoz-not-following-sun-coding-guidelines: > > public void setFile(File file) { > _file = file; > } Problem is when file is already a protected variable. We cannot rename that to _file in Ant1 while at the same time be consistent in naming. > > It makes a clear distinction. :) > I agree it does, but so does the following ;-) this.file = file; Though I made this change, I was doing it just because QA complained - otherwise, I wouldn't have. As this seems to be snowballing into issues, I will revert the commit and lets see where the discussion heads... > btw FYI the next version of IDEA codename Ariadna (Ariadne) will make the > distinction between instance, formal parameter and local variable. Cool. > > Stephane > Cheers, Magesh -- To unsubscribe, e-mail: For additional commands, e-mail: