ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Chambery" <tchamb...@hotmail.com>
Subject Re: [PATCH] change the way the GeneralDeploymentDescriptor (GDT) picks up a user-built manifest file
Date Fri, 11 Jan 2002 22:30:50 GMT

----- Original Message -----
From: "Holger Engels" <hengels@mercatis.de>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Friday, January 11, 2002 12:23 PM
Subject: Re: [PATCH] change the way the GeneralDeploymentDescriptor (GDT)
picks up a user-built manifest file


> On Fri, 11 Jan 2002, Todd Chambery wrote:
>
> > My first crack at this was less than impressive, but this one I think
solves
> > the problem in a more intuitive way:
> >
> > Old GDT:  Grabs a user-created manifest from
> >
> >     descriptor_root/basejarname-manifest.mf
> >
> > this is not intuitive, and in my case requires an extra mapping/copy
step
> > before running <ejbjar>.
> >
> > New GDT:  Grabs a user-created manifest from
> >
> >     descriptor_root/dir_of_current_descriptor/manifest.mf
> >
>
> I think that's by far less intuitive. Why do you want to collect files,
> that end up in the same directory from different directories? Why not use
> the same naming convention for _all_ META-INF files? I'd agree, if we
> change it to:
>
>      descriptor_root/basejarname-MANIFEST.MF

I can see validity of doing it this way (since it makes explicit the
association between the descriptors and the manifest), except from the
standpoint of project organization.  With my current project, the
ejb-jar.xml, WAS-specific files and the manifest for each (of 53 beans) are
all kept in their own directory under the descriptor root, a la
descriptor_root/foo/META-INF/.  Picking up the manifest from the current
descriptor directory is intuitive in the sense that you wouldn't put a
manifest in directory with descriptors for a jar to which it doesn't belong.
Consider even the case of a single descriptor directory containing a hundred
basejarname-descripfile.xm*, if you wanted a single manifest for all, it
still gets picked up if it's in that directory.

That all said, I think it's probably worthwhile to have the jarname
prepended to the manifest for clarity, but it should be looked for in the
directory of the current descriptor particular ejb jar.  So instead of this
line:

File manifestFile = new File(config.descriptorDir, currDescriptorDir +
File.separator + MANIFEST_FILE);

this:

File manifestFile = new File(config.descriptorDir, currDescriptorDir +
File.separator + jarname + "-" + MANIFEST_FILE);

or somehting along that line
.
>
>
> BTW: META-INF/manifest.mf is wrong, META-INF/MANIFEST.MF would be correct

I actually thought this too, but the current GDT uses small case, so I went
with that.

>
> Cheers,
>
> Holger
>
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message