ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/types EnumeratedAttribute.java
Date Tue, 08 Jan 2002 16:42:59 GMT
From: <sbailliez@apache.org>
>   Modified:    src/main/org/apache/tools/ant/types
EnumeratedAttribute.java
>   Log:
>   Fallback to protected attributes to prevent breakage.

>        /**
>         * The selected value in this enumeration.
>         */
>   -    private String value;
>   +    protected String value;
>
>        /**
>         * the index of the selected value in the array.
>         */
>   -    private int index;
>   +    protected int index;
>

Aren't we back at square one? ;-)

+1 to convert
    protected int index;
to
    private int index;
and to provide a 'protected final int getIndex()' method instead.

-1 to convert 'protected String value' to 'private String value'
because it would break backwards compatibility.

Cheers,
Magesh


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message