ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/types EnumeratedAttribute.java
Date Sun, 06 Jan 2002 17:40:41 GMT
From: <sbailliez@apache.org>

>        /**
>   +     * the index of the selected value in the array.
>   +     */
>   +    protected int index;

IMHO, wouldn't it be tighter if you mark this private 
and provide a "protected final int getIndex()" method?
This way it is ensured that EnumeratedAttribute has
control over the value of the index variable.

Cheers,
Magesh


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message