ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 5906] - Can't pass double quotes as an argument, turns into whitespace
Date Fri, 01 Feb 2002 03:46:25 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5906>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5906

Can't pass double quotes as an argument, turns into whitespace





------- Additional Comments From umagesh@apache.org  2002-02-01 03:46 -------
The 'problem' lies in Commandline.java.  The method translateCommandline does
some checks which need to go away.  I feel these checks are misplaced.

if (current.length() != 0) {  //REMOVE
    v.addElement(current.toString());
} //REMOVE

if (state == inQuote || state == inDoubleQuote) { //REMOVE
    throw new BuildException("unbalanced quotes in " + to_process);//REMOVE
}//REMOVE

Removing this will affect testcases which check to see if single quotes are
ended properly, etc.  So, I wish to get inputs on why this check is being made 
*here*, before I go fixing it.

I also noticed that the exact same code for translateCommandLine is repeated
in FileUtils.java.  Why?  Can't we make one call the other?  I know you cannot
do away with the method completely because it is a public API....

Cheers,
Magesh

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message