ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbaill...@apache.org
Subject cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce P4Edit.java
Date Tue, 08 Jan 2002 22:50:43 GMT
sbailliez    02/01/08 14:50:43

  Modified:    src/main/org/apache/tools/ant/taskdefs/optional/perforce
                        P4Edit.java
  Log:
  Fix bad coding style.
  then/else parts of if statement and loop body must always been enclosed
  in a block statement.
  
  Revision  Changes    Path
  1.5       +6 -2      jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Edit.java
  
  Index: P4Edit.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/perforce/P4Edit.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- P4Edit.java	27 Nov 2001 18:04:53 -0000	1.4
  +++ P4Edit.java	8 Jan 2002 22:50:43 -0000	1.5
  @@ -78,8 +78,12 @@
       }
   
       public void execute() throws BuildException {
  -        if(change != null ) P4CmdOpts = "-c "+change;
  -        if(P4View == null) throw new BuildException("No view specified to edit");
  +        if(change != null ) {
  +          P4CmdOpts = "-c "+change;
  +        }
  +        if(P4View == null) {
  +          throw new BuildException("No view specified to edit");
  +        }
           execP4Command("-s edit "+P4CmdOpts+" "+P4View, new SimpleP4OutputHandler(this));
       }
   }
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message