ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sbaill...@apache.org
Subject cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs Javadoc.java
Date Tue, 08 Jan 2002 22:44:35 GMT
sbailliez    02/01/08 14:44:35

  Modified:    src/main/org/apache/tools/ant/taskdefs Javadoc.java
  Log:
  Fix bad coding style.
  then/else parts of if statement and loop body must always been enclosed
  in a block statement.
  
  Revision  Changes    Path
  1.69      +13 -7     jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java
  
  Index: Javadoc.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Javadoc.java,v
  retrieving revision 1.68
  retrieving revision 1.69
  diff -u -r1.68 -r1.69
  --- Javadoc.java	12 Dec 2001 09:17:36 -0000	1.68
  +++ Javadoc.java	8 Jan 2002 22:44:34 -0000	1.69
  @@ -751,10 +751,11 @@
           toExecute.setExecutable( getJavadocExecutableName() );
   
   // ------------------------------------------------ general javadoc arguments
  -        if (classpath == null)
  +        if (classpath == null) {
               classpath = Path.systemClasspath;
  -        else
  +        } else {
               classpath = classpath.concatSystemClasspath("ignore");
  +        }
   
           if (!javadoc1) {
               toExecute.createArgument().setValue("-classpath");
  @@ -767,10 +768,12 @@
                                                   System.getProperty("path.separator") +
classpath.toString());
           }
   
  -        if (version && doclet == null)
  +        if (version && doclet == null) {
               toExecute.createArgument().setValue("-version");
  -        if (author && doclet == null)
  +        }
  +        if (author && doclet == null) {
               toExecute.createArgument().setValue("-author");
  +        }
   
           if (javadoc1 || doclet == null) {
               if (destDir == null) {
  @@ -1027,7 +1030,9 @@
           Vector addedPackages = new Vector();
   
           String[] list = sourcePath.list();
  -        if (list == null) list = new String[0];
  +        if (list == null) {
  +          list = new String[0];
  +        }
   
           FileSet fs = new FileSet();
           fs.setDefaultexcludes(useDefaultExcludes);
  @@ -1123,10 +1128,11 @@
                   queuedLine = line;
               } else {
                   if (queuedLine != null) {
  -                    if (line.startsWith("Building "))
  +                    if (line.startsWith("Building ")) {
                           super.processLine(queuedLine, Project.MSG_VERBOSE);
  -                    else
  +                    } else {
                           super.processLine(queuedLine, Project.MSG_INFO);
  +                    }
                       queuedLine = null;
                   }
                   super.processLine(line, messageLevel);
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message