ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject cvs commit: jakarta-ant build.xml
Date Mon, 07 Jan 2002 17:06:29 GMT
bodewig     02/01/07 09:06:29

  Modified:    .        build.xml
  Log:
  Skip SQLExecTest if the testcase and the <sql> implementation would be
  loaded by different classloaders.
  
  package private access is only allowed if the classes belong to the
  same "runtime package", which is the fully qualified package name plus
  the defining classloader.  Enough reading of JLS and VMSPEC for me for
  today 8-)
  
  We probably could code around the problem by placing a subclass of
  SQLExec into the same classloader as SQLExecTest and invoke methods on
  this subclass.
  
  Revision  Changes    Path
  1.221     +23 -8     jakarta-ant/build.xml
  
  Index: build.xml
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/build.xml,v
  retrieving revision 1.220
  retrieving revision 1.221
  diff -u -r1.220 -r1.221
  --- build.xml	7 Jan 2002 06:29:42 -0000	1.220
  +++ build.xml	7 Jan 2002 17:06:28 -0000	1.221
  @@ -207,6 +207,13 @@
           <isset property="jdk1.2+" />
         </and>
       </condition>
  +
  +    <condition property="run.sqlexec.test">
  +      <or>
  +        <equals arg1="${junit.fork}" arg2="true" />
  +        <equals arg1="${build.sysclasspath}" arg2="only" />
  +      </or>
  +    </condition>
     </target>
   
     <!--
  @@ -885,16 +892,20 @@
             <exclude name="${optional.package}/sitraka/*.java" unless="jakarta.oro.present"
/>
             <exclude name="${optional.package}/ReplaceRegExpTest.java"
                      unless="some.regexp.support" />
  -
  -          <!-- it's an abstract class, not a test -->
  -          <exclude name="org/apache/tools/ant/taskdefs/optional/AbstractXSLTLiaisonTest.java"
/>
  -          <exclude name="org/apache/tools/ant/taskdefs/optional/XslpLiaisonTest.java"
unless="xslp.present"/>
  -          <exclude name="org/apache/tools/ant/taskdefs/optional/XalanLiaisonTest.java"
unless="xalan.present"/>
  +          <exclude name="org/apache/tools/ant/taskdefs/optional/XslpLiaisonTest.java"

  +                   unless="xslp.present"/>
  +          <exclude name="org/apache/tools/ant/taskdefs/optional/XalanLiaisonTest.java"

  +                   unless="xalan.present"/>
   
             <exclude name="org/apache/tools/ant/taskdefs/optional/AdaptxLiaisonTest.java"
                      unless="adaptx.present"/>
             <exclude name="org/apache/tools/ant/taskdefs/optional/AdaptxLiaisonTest.java"
                      unless="xerces.present"/>
  +          <exclude name="${optional.package}/perforce/*.java"
  +                   unless="jakarta.oro.present" />
  +
  +          <!-- it's an abstract class, not a test -->
  +          <exclude name="org/apache/tools/ant/taskdefs/optional/AbstractXSLTLiaisonTest.java"
/>
   
             <!-- ehm, this is not really a TraX test but rather a xalan2 test..-->
             <exclude name="org/apache/tools/ant/taskdefs/optional/TraXLiaisonTest.java"
unless="xalan2.present"/>
  @@ -905,11 +916,15 @@
             <exclude name="${optional.package}/junit/JUnitTestRunnerTest.java"
                      unless="jdk1.2+" />
   
  -          <exclude name="${optional.package}/perforce/*.java"
  -                   unless="jakarta.oro.present" />
  -
             <!-- interactive test -->
             <exclude name="org/apache/tools/ant/taskdefs/TestProcess.java" />
  +
  +          <!--  This test only passes if SQLExecTest and SQLExec have
  +          been loaded by the same classloader - will throw
  +          IllegalAccessExceptions otherwise.  -->
  +          <exclude name="org/apache/tools/ant/taskdefs/SQLExecTest.java"
  +                   unless="run.sqlexec.test" />
  +
           </fileset>
         </batchtest>
   
  
  
  

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message