ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran" <stev...@iseran.com>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/types E numeratedAttribute.java
Date Tue, 08 Jan 2002 17:30:10 GMT

----- Original Message -----
From: "Stephane Bailliez" <sbailliez@imediation.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Sent: Tuesday, January 08, 2002 00:29
Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/types E
numeratedAttribute.java


>
> I'm totally 150% OK for this but I'd would also like us to focus on having
> the code cleaned up to be homogeneous and respect the Jakarta coding lines
> especially considering braces, indentation and naming. There has been
> lengthy debate about this on general and commons about how anarchic was
> starting to be the code in Jakarta and even though in Ant a lot of code
has
> been done by non-committers this does not prevent us from having severe
> guidelines and respect them.

I am +1 on this. Sometimes when I look at tasks, especially optional ones, I
am sorely tempted to hit the jstyle button in jedit to sort out their
structure, but that breaks the 'be consistent' rule.

> I think Stefan wanted to have severe guidelines about task submission and
> has been -1, so this is somewhat contradictory. Starting with severe
> guidelines at the beginning and maybe relax with time is exactly the same
as
> put everything in private and everything final and relax when possible. No
?
>
> If we do this then we have to be more responsive about user willing to
> integrate Ant.
> For instance I think we did not take much in account the critics from Jeff
> McGuire about integrating Ant w/ Eclipse.
>
> For the sake of clarity and so that it is crystal-clear I will commit a
> document about these coding guidelines ASAP as a starting point. Comments
?

Stick the stuff in ant_task_guidelines.html; there isnt much on coding
practices there at all.



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message