ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@apache.org>
Subject Re: [PATCH] zip/jar improvements * 2
Date Thu, 31 Jan 2002 15:33:39 GMT
From: "Brian Deitte" <bdeitte@macromedia.com>

> > Is it possible to make this configurable by letting
> > the user specify whether the file is to be added
> > or duplicated with the default option set to duplicated?
> > This would ensure backwards compatibility as well
> > as let the user take her pick.
> 
> Sure, I can do this, but is there any case where people 
> really want duplicate files within the same directory?  
> I was surprised this was even possible!

Good or bad, we need to ensure 'backwards compatibility',
unless, of course, you call for a vote and the committers
feel that it is worth breaking.

> 
> > In your code, I noticed that you have used //
> > to comment private variables.  Use commenting style
> > recognized by javadoc instead.  Please also provide
> > valid javadoc comments for all methods that
> > you introduce.
> 
> I confess, I didn't comment as much as I should have 
> for the amount of changes I made.  I'll add some more.  
> An unrhetorical question, though: do people javadoc 
> private variables?  I can change this, but I'm just 
> curious, because I've never worked with a group that 
> does this.

Have you ever wondered why javadoc has the -private 
option? ;-)

> 
> Thanks again, Brian
> 

Cheers,
Magesh

****************************************************
*  Doctor: A person who kills your ills by pills,  *
*  and then kills you with his bills.              *
****************************************************



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message