From ant-dev-return-20700-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org Tue Dec 04 00:48:21 2001 Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@apache.org Received: (qmail 20498 invoked from network); 4 Dec 2001 00:48:21 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 4 Dec 2001 00:48:21 -0000 Received: (qmail 20740 invoked by uid 97); 4 Dec 2001 00:48:25 -0000 Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org Received: (qmail 20724 invoked by uid 97); 4 Dec 2001 00:48:24 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 20713 invoked from network); 4 Dec 2001 00:48:24 -0000 From: "Conor MacNeill" To: "Ant Developers List" Subject: RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java Date: Tue, 4 Dec 2001 11:51:45 +1100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) In-Reply-To: <20011201033140.72338.qmail@icarus.apache.org> X-MIMEOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Importance: Normal X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Doesn't this break backward compatability? I don't think we can just remove public methods. Conor > -----Original Message----- > From: donaldp@apache.org [mailto:donaldp@apache.org] > Sent: Saturday, 1 December 2001 2:32 PM > To: jakarta-ant-cvs@apache.org > Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant > Project.java > > > donaldp 01/11/30 19:31:40 > > Modified: src/main/org/apache/tools/ant Project.java > Log: > Remove unsetProperty() because it allows tasks to break immutability. > > Revision Changes Path > 1.82 +0 -15 > jakarta-ant/src/main/org/apache/tools/ant/Project.java > > Index: Project.java > =================================================================== > RCS file: > /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v > retrieving revision 1.81 > retrieving revision 1.82 > diff -u -r1.81 -r1.82 > --- Project.java 2001/11/30 17:35:06 1.81 > +++ Project.java 2001/12/01 03:31:40 1.82 > @@ -342,21 +342,6 @@ > } > > /** > - * unset a named property, unless it is a user property. > - * the immutability policy is not implemented at this level > - * @param name name of property > - */ > - public void unsetProperty(String name) { > - // command line properties take precedence > - if (null != userProperties.get(name)) { > - log("Won\'t unset user property " + name, MSG_VERBOSE); > - return; > - } > - log("Unsetting project property: " + name, MSG_DEBUG); > - properties.remove(name); > - } > - > - /** > * set a user property, which can not be overwritten by > * set/unset property calls > * @see #setProperty(String,String) > > > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > > -- To unsubscribe, e-mail: For additional commands, e-mail: