ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@cortexebusiness.com.au>
Subject RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant Project.java
Date Tue, 04 Dec 2001 00:51:45 GMT
Doesn't this break backward compatability? I don't think we can just remove
public methods.

Conor


> -----Original Message-----
> From: donaldp@apache.org [mailto:donaldp@apache.org]
> Sent: Saturday, 1 December 2001 2:32 PM
> To: jakarta-ant-cvs@apache.org
> Subject: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
> Project.java
>
>
> donaldp     01/11/30 19:31:40
>
>   Modified:    src/main/org/apache/tools/ant Project.java
>   Log:
>   Remove unsetProperty() because it allows tasks to break immutability.
>
>   Revision  Changes    Path
>   1.82      +0 -15
> jakarta-ant/src/main/org/apache/tools/ant/Project.java
>
>   Index: Project.java
>   ===================================================================
>   RCS file:
> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Project.java,v
>   retrieving revision 1.81
>   retrieving revision 1.82
>   diff -u -r1.81 -r1.82
>   --- Project.java	2001/11/30 17:35:06	1.81
>   +++ Project.java	2001/12/01 03:31:40	1.82
>   @@ -342,21 +342,6 @@
>        }
>
>        /**
>   -     * unset a named property, unless it is a user property.
>   -     * <i>the immutability policy is not implemented at this level</i>
>   -     * @param name name of property
>   -     */
>   -    public void unsetProperty(String name) {
>   -        // command line properties take precedence
>   -        if (null != userProperties.get(name)) {
>   -            log("Won\'t unset user property " + name, MSG_VERBOSE);
>   -            return;
>   -        }
>   -        log("Unsetting project property: " + name, MSG_DEBUG);
>   -        properties.remove(name);
>   -    }
>   -
>   -    /**
>         * set a user property, which can not be overwritten by
>         * set/unset property calls
>         * @see #setProperty(String,String)
>
>
>
>
> --
> To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message