ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Murdoch" <adammurdoch...@yahoo.com>
Subject RE: [PATCH] IntrospectionHelper
Date Tue, 18 Dec 2001 22:07:12 GMT


> From: Stefan Bodewig [mailto:bodewig@apache.org]
>
> > This patch fixes this so that Ant will only ever call one of the
> > 'addConfigured', 'add' or 'create' methods for a nested element.
>
> It does so in a way that addConfigured will always be ignored if one
> of the other two methods is present.  addConfigured seems to be the
> "higher level" of add, so I'd like to see it take precedence if it is
> present.
>

The plan (for the patch) was to treat them all equally and just pick up the
last one it finds.  IntrospectionHelper was almost doing that, it just
wasn't cleaning out nestedStorers if it got a create or add method *after*
an addConfigured.  Which meant you'd end up with the create/add method in
nestedCreators, and the addConfigured in nestedStorers.

> Conor, any opinion here?  You've invented addConfigured.
>
> Others?
>

Making addConfigured the preferred method (over create and add) seems like a
good thing.  Could just be a recommendation in the doc.


Adam


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message