ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: Immutability improvement patch
Date Mon, 03 Dec 2001 09:10:21 GMT
----- Original Message -----
From: "Jose Alberto Fernandez" <j_a_fernandez@yahoo.com>
>>     ProjectHelper.replaceProperties(project, msg,
project.getProperties());
>> (from Echo.java)
>>
>> although in this case is there a reason why this substitution isn't done
>> before calling addText?  Its done automatically on calls to setXXX
methods.
>> Do we not always want property expansion in element text?  I guess
<script>
>> wouldn't be too happy with that, huh?!  :)
>>
> Saw your changes, do you really think it is necessary to require people to
use
> ProjectHelper? That class seem to me should be considered an internal API.
> If it wasn't for deprecation I would suggest make it package scope.

Just to clarify: the above line of code was not part of any or my changes...
that was already part of Echo.java.

Peter has already addressed this issue somewhat by other commits.

    Erik



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message