ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject Re: [PATCH] Immutability Patch 2
Date Thu, 06 Dec 2001 10:18:55 GMT
----- Original Message -----
From: "Peter Donald" <peter@apache.org>

> Okay. I made a change here by making that constructor protected rather
than
> public. I also readded setUserProperty() so as not to break binary
> compatability. However I nooped it and made it print out a annoying
message.

Cool.

> I also removed isUserProperty as it was never used anywhere ;)

Oops... that was added in one of my many refactoring attempts.

> Well I will remove the blurb about available just in case it gives people
> ideas ;)

Looks good to me.

> Could you check I applied the patch correctly and didn;'t miss anything ;)

It all looks fine and works fine for me.  Many thanks.

Now if I can just get folks convinced that <available>'s hole should be
patched.....  :))

    Erik



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message