ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <jakarta-...@ehatchersolutions.com>
Subject [PATCH] Immutability Patch 2
Date Tue, 04 Dec 2001 02:14:12 GMT
Yup, its me again!  :)

The issue that Peter brought up with ant/antcall is being addressed in this
patch.  Property was modified to allow setting user properties without
warning, but that mode cannot be enabled from a <property> statement (I
removed the setUserProperty method as it was undocumented and probably only
used by ant/antcall under the covers).

Project had several calls to setProperty in it, which in theory could
generate a deprecated warning.  I added an internal method to allow setting
"basedir" and a couple of other places to set a property silently if it
wasn't a user property (setPropertyInternal, its protected, although private
would have been ok with me too).

I modified getProperties and getUserProperties to return copies of the
collections to prevent modifications of properties that way.

I updated WHATSNEW (maybe the <available> back door shouldn't be mentioned
there - maybe we should just close that open door :).

This should be yet another step forward in the battle against property
mutability.  Let me know if there are any problems with this patch or if
I've missed something.

Thanks,
    Erik


Mime
View raw message