Return-Path: 
 <ant-dev-return-20604-qmlist-jakarta-archive-ant-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@apache.org
Received: (qmail 64967 invoked from network); 30 Nov 2001 20:23:29 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 30 Nov 2001 20:23:29 -0000
Received: (qmail 1577 invoked by uid 97); 30 Nov 2001 20:23:31 -0000
Delivered-To: qmlist-jakarta-archive-ant-dev@jakarta.apache.org
Received: (qmail 1536 invoked by uid 97); 30 Nov 2001 20:23:30 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:ant-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:ant-dev-help@jakarta.apache.org>
List-Post: <mailto:ant-dev@jakarta.apache.org>
List-Id: "Ant Developers List" <ant-dev.jakarta.apache.org>
Reply-To: "Ant Developers List" <ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 1525 invoked from network); 30 Nov 2001 20:23:30 -0000
Message-ID: <015301c179dc$de98b3c0$d0a4f40f@nordwand>
From: "Steve Loughran" <steve_l@iseran.com>
To: "Ant Developers List" <ant-dev@jakarta.apache.org>
References: <m3vgfsv2th.fsf@bodewig.bost.de>
 <005101c179af$749739b0$0100a8c0@jose>
Subject: Re: To fail or not to fail
Date: Fri, 30 Nov 2001 12:23:26 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2600.0000
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N


I think adding if and unless tests to fail would suffice for much now.
Complex conditions can go into a <condition> test which immediately preceeds
the <fail>.

Note that there is already a sort of hack to implement <fail if> by virtue
of the fact that many tasks fail if the params are wrong. So if you set up
the parameters right from a condition call you can force a conditional
failure:-

<condition  name="sleeptime" value="-10" >
 <isset name="env.TOMCAT_HOME />
</condition>
<property name="sleeptime" value="0" />
<!-- fails if sleeptime is negative -->
<sleep seconds="${sleeptime}"/>


Thus adding a conditional failure to <fail> is simply a cleaning up of
existing behaviour.

-steve



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>