ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] Whole directory moves optimized
Date Fri, 02 Nov 2001 13:44:20 GMT
On 1 Nov 2001, Magesh Umasankar <umagesh@rediffmail.com> wrote:

> This patch does precisely that when 'normal' directory
> moves are performed.  It operates at the fileset level.
> Each fileset that has an empty 'notIncluded' file/dir 
> list is treated as a candidate for a dir rename since
> this means that all files in the dir has been included.

Depending on the fileset we are operating on, this may seriously
decrease performance, achieving the opposite of what you want to do.

Say we are copying only a few files out of a very large directory
tree, almost all directories are excluded by default.  In the current
situation many directories will not be scanned at all (the fast mode),
but if we apply your patch, all directories will be scanned.

It would probably be OK to just perform the additional scan in the
move case, but even then it may make things worse than they are now.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message