ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [PATCH] TaskHandler fixes
Date Fri, 02 Nov 2001 10:33:40 GMT
On Thu, 01 Nov 2001, Ovidiu Predescu <ovidiu@cup.hp.com> wrote:

> In 1.4, if an extension task is declared to implement TaskContainer,
> all the contained tasks are added correctly to the extension
> task. However the contained tasks will not have the attribute setter
> methods invoked as it should happen. This doesn't happen with tasks
> defined in Ant itself, only with new extension tasks defined in
> additional jar files.

It doesn't happen for the built-in TaskContainers as they invoke
Task.perform instead of Task.execute - which has the additional side
effect of firing build events.

While I agree that "configuring" the tasks (Ant-speak for invoking the
attribute setters) should happen for the children of TaskContainer
tasks the same way it happens for the other child elements - that's
why I'll commit your patch - we should probably advise people who
implement TaskContainer to use perform instead of execute as well.

Stefan

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message