ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Holger Engels <heng...@mercatis.de>
Subject [PATCH] ant task with (nested) fileset(s)
Date Fri, 09 Nov 2001 13:11:27 GMT

This patch obsoletes the previous patch with the same subject


On Fri, 9 Nov 2001, Jose Alberto Fernandez wrote:

> From: "Holger Engels" <hengels@mercatis.de>
> 
> > On Fri, 9 Nov 2001, Jose Alberto Fernandez wrote:
> > 
> > > I think it is best not making the task extend from MatchingTask but
> > > still support <fileset> elements or as I call it <antfileset> :-)
> > > 
> > > <ant target="xx">
> > >     <fileset dir="sub">
> > >         <include name="sub1/**/build.xml" />
> > >     </fileset>
> > > </ant>
> > > 
> > > here the different meanings of dir are kept appart. And in this particular
case
> > > you will be using the "basedir" defined in the sub-buildfiles. If you use
> > > <ant dir="xyz"> then it should mean use this value for "basedir", as
it does today.
> > > 
> > 
> > Ok, I agree. I'm going to remove the matching task stuff and only support 
> > nested antfilesets. This makes it better understandable.
> > 
> > If I got you right, the 'dir' attribute of ant should override the dir of 
> > any particular fileset.
> 
> No, not the dir of the fileset (which is used to find the files in the fileset) but
> the value used inside the task to compute the basedir property of the
> subbuild. Which is quite different.
>

the ant task's dir attribute ..
.. is the project's basedir for all antfiles of all filesets, if specified
.. does not override the antfileset's basedir meaning for finding files

if no dir argument is specified ..
.. dir defaults to the current project's dir for the single antfile 
   argument
.. the basedir arguments of the antfilesets are used as the project's 
   basedir

>
> I would also make the attribute "antfile" and <antfileset> mutially exclusive.
> That would probably keep strange combinations to become a "bad feature" ;-)
> 

ok .. did that


Holger

Mime
View raw message