ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Vernum <Tim.Ver...@macquarie.com>
Subject RE: [PATCH] Bug 5178: ant's shell script doesn't grok space(s) in path!
Date Fri, 30 Nov 2001 00:49:49 GMT
From: Denis N. Antonioli [mailto:antonioli@ifi.unizh.ch]

> This patch fixes bug 5178. it has been tested on MacOSX and cygwin.

I believe your patch will break the script when the lib directory is empty.

This change:

-DIRLIBS=${ANT_HOME}/lib/*.jar
-for i in ${DIRLIBS}
+DIRLIBS="${ANT_HOME}/lib"
+for i in "${DIRLIBS}/"*.jar

means that this test

+    if [ "$i" != "$DIRLIBS" ] ; then

is no longer valid.

(BTW: Is there a reason why you decided to remove the '{' '}' around the variables?)


NOTICE
This e-mail and any attachments are confidential and may contain copyright material of Macquarie
Bank or third parties. If you are not the intended recipient of this email you should not
read, print, re-transmit, store or act in reliance on this e-mail or any attachments, and
should destroy all copies of them. Macquarie Bank does not guarantee the integrity of any
emails or any attached files. The views or opinions expressed are the author's own and may
not reflect the views or opinions of Macquarie Bank. 


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message