ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 4411] - FTP task scandir method bug
Date Fri, 16 Nov 2001 23:09:22 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4411>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4411

FTP task scandir method bug

sbailliez@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ant-dev@jakarta.apache.org
         AssignedTo|ant-dev@jakarta.apache.org  |sbailliez@apache.org



------- Additional Comments From sbailliez@apache.org  2001-11-16 15:09 -------
Edouard, as Stefan says, the fact that you post the whole file or a simple 
snippet makes it difficult to see what are the real changes you did.

As we don't even know what is your reference source, it makes it even more 
difficult to do a diff. Plus in the whole file you added a loop to print out 
statements in french that you commented. statements are commented but the loop 
remains.

If you don't know how to deal with cvs, please identify *clearly* the lines you 
changed. As far as I can see the changes are related to the case "if 
(file.isDirectory())" where you moved up the vpath + file.getName() and you 
added a

if (fast && couldHoldIncluded(name)) {
  scandir(file.getName(), name+File.separator, fast);
}

you did a change in listFiles as well.

Please confirm this ASAP with the motivation.

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message