ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: [patch] new file: jakarta-ant/src/script/antRun.pl
Date Thu, 15 Nov 2001 08:11:40 GMT
Added antRun.pl - tah.


On Thu, 15 Nov 2001 08:13, Jeff Tulley wrote:
> Here is a better version.  It seems that the prefixing with the path is
> (unfortunately) necessary on NetWare.  So, I check for the OS, if not on
> NetWare, I do the chdir and then execute the rest of the command. Also, I
> don't know what I was trying to do with the "-" if statement.  I think I
> wrote that before I understood the difference between VM and non VM command
> launchers and when each is used.  I just took that code out, since I wasn't
> even utilizing it through what I had done in Exec.java and Execute.java
>
> I learned the semantics of the <exec> task and tested this out with some
> simple scripts.
>
> I still need to send up the Execute stuff (will do that very soon, now that
> I have some more confidence in it).
>
> Jeff Tulley  (jtulley@novell.com)
> (801)861-5322
> Novell, Inc., the leading provider of Net services software.
>
> >>> bodewig@apache.org 11/14/01 2:41:57 AM >>>
>
> Hi Jeff,
>
> I noticed you've commented out the chdir call in the script - is that
> intended?
>
> You seem to prefix the directory to the command to execute, this is
> not what antRun does - there is a difference between
>
> cd /tmp
> ls
>
> and
>
> /tmp/ls
>
> at least in most situations 8-)
>
> I guess I'm simply not understanding the script, which may very well
> be as my Perl has become more than a little rusty.
>
> Also, I just now realized that your first patches applied to Exec.java
> - this file isn't used anywhere anymore, <exec> corresponds to
> ExecTask.java which in turn uses Execute.java, I guess you want to do
> something like the attached patch.
>
> Stefan
>
> Index: src/main/org/apache/tools/ant/taskdefs/Execute.java
> ===================================================================
> RCS file:
> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/Execute.java,v
> retrieving revision 1.24
> diff -u -r1.24 Execute.java
> --- src/main/org/apache/tools/ant/taskdefs/Execute.java	2001/11/02
> 07:56:52	1.24 +++
> src/main/org/apache/tools/ant/taskdefs/Execute.java	2001/11/14 09:29:08 @@
> -119,6 +119,11 @@
>              // OS/2 - use same mechanism as Windows 2000
>              shellLauncher = new WinNTCommandLauncher(new
> CommandLauncher()); }
> +        else if ( Os.isFamily("netware") ) {
> +            // Novell Netware - use the Perl script
> +            shellLauncher = new ScriptCommandLauncher("bin/antRun.pl",
> +                                                      new
> CommandLauncher()); +        }
>          else if ( Os.isFamily("windows") ) {
>              // Windows.  Need to determine which JDK we're running in

-- 
Cheers,

Pete

------------------------------------------
I just hate 'yes' men, don't you Smithers?
------------------------------------------


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message