ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: [PATCH] ant task with (nested) fileset(s)
Date Sat, 10 Nov 2001 12:51:34 GMT
On Sat, 10 Nov 2001 23:11, Jose Alberto Fernandez wrote:
> From: "Peter Donald" <donaldp@apache.org>
>
> > I am still fairly sure I don't like anton (or javaon) style functionality
> > at all. Basically it amounts to limited version of foreach where only one
> > var can change each iteration. I can't see how either can lead to good
> > build practices - anyone care to enlighten me ?
>
> In the case of <javaon> I agree with your argument (although there is still
> the issue of having allowed <execon> as part of ANT in the first place)
> those asking for <javaon>, I think are just asking for symmetry on the
> tasks provided by ANT.
>
> With respect to <ant> (or <anton>) fileset functionality I disagree with
> your assesment. The question is whether the best practice is to have to
> modify a main-buildfile everytime a new subproject is added, 

thats the way I would do it.

> or this can be
> done by simply installing the subproject in the right location in the
> source tree.

eww. Builds are meant to be as reproducible as possible between different 
environments. This definetly breaks this mold.

That said I think my orignal vote was -0 so Im not blocking it or anything. 
Just think it is bad practices ;)

-- 
Cheers,

Pete

---------------------------------------------------
"Therefore it can be said that victorious warriors 
win first, and then go to battle, while defeated 
warriors go to battle first, and then seek to win." 
              - Sun Tzu, the Art Of War
---------------------------------------------------

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message