ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: [PATCH] Translate.java (Was: Re: [SUBMIT] Translate - a useful task for i18n)
Date Sat, 03 Nov 2001 04:08:28 GMT
On Sat, 3 Nov 2001 13:54, Magesh Umasankar wrote:
> On Sat, 03 Nov 2001 Peter Donald wrote :
>
> > I should note that I changed all protected members to 
> > private. Tell me if this causes any issues ;)
> 
> No, it doesn't cause any issues - the idea was to open 
> up the methods that may be overridden if at all a task 
> is going to be extending this one in the future...

if the need arises we can deal with it then. Making them private makes it 
easier evolve because no one will try to use them without making us aware of 
it.
 
> I had noticed s small problem after I had submitted this
> task and I had followed it up with a revision.  I see 
> that the revision did not get applied.  Here is a patch 
> that will get rid of this bug.

applied.

-- 
Cheers,

Pete

*-------------------------------------*
| Does the name `Pavlov' ring a bell? |
*-------------------------------------*

--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message