ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jose Alberto Fernandez" <j_a_fernan...@yahoo.com>
Subject Re: [PATCH] Copy task recognizes URLs as file attributes
Date Tue, 27 Nov 2001 21:08:48 GMT
Not that my vote count for anything, but I think it is a bad idea to
overload the meaning of an attribute in such a way.

If you want to allow copy to take URLs then add an "url" attribute
for that. The original patch already added a bunch of other attributes
which are specific to URLs.

Why do we need to change the signature of setFile(File) to setFile(String)
and so on? You can define setUrl(URL) or whatever. And let introspection
do its job in a centralized fashion.

----- Original Message ----- 
From: "Magesh Umasankar" <umagesh@rediffmail.com>
To: <ant-dev@jakarta.apache.org>
Sent: Tuesday, November 27, 2001 7:46 PM
Subject: Re: [PATCH] Copy task recognizes URLs as file attributes



Please refer to the following link for background info
on this thread:
http://marc.theaimsgroup.com/?t=100431828900002&w=2&r=1

Do any of you have issues with the concept of letting
the file attribute of <copy> take URLs too as a valid
value?  If not, I plan to commit this, after refactoring 
it a bit more.

Magesh
 


--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>



--
To unsubscribe, e-mail:   <mailto:ant-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:ant-dev-help@jakarta.apache.org>


Mime
View raw message