Return-Path: 
 <ant-dev-return-18309-apmail-jakarta-ant-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@jakarta.apache.org
Received: (qmail 91636 invoked by uid 500); 11 Oct 2001 10:51:43 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
list-help: <mailto:ant-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 91609 invoked from network); 11 Oct 2001 10:51:38 -0000
Content-Type: text/plain;
  charset="utf-8"
From: Peter Donald <donaldp@apache.org>
To: ant-dev@jakarta.apache.org
Subject: Re: [PATCH] Path.java does not support inclusion of directories
Date: Thu, 11 Oct 2001 20:08:08 +1000
X-Mailer: KMail [version 1.3.1]
References: <3BC498BB.5070109@collab.net>
In-Reply-To: <3BC498BB.5070109@collab.net>
X-Wisdom-Cookie: .
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20011011101506.FRZS13193.mss.rdc2.nsw.optushome.com.au@there>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

On Thu, 11 Oct 2001 04:51, Jason Brittain wrote:
>    <path id="foo">
>      <fileset dir="/tmp/bar" includes="*"/>
>    </path>
>
> and in the dir /tmp/bar is
>
> /tmp/bar/
>           dir1/
>           dir2/
>           file1.ext
>
> Before the patch, the contents of the path (on UNIX) would look like this:
>
> "/tmp/bar/file1.ext"
>
> Note the missing dir1 and dir2 paths that are supposed to be in there.
> After the patch the contents of the path (on UNIX) would correctly be:
>
> "/tmp/bar/file1.ext:/tmp/bar/dir1:/tmp/bar/dir2"

The problem is that this is not backwards compatible and would break 
virtually every build file I use so it will never make it in as is. You may 
be able to add an extra attribute includedirs that defaults to false though. 
Not sure - anyone else got any better ideas ?


> Can this patch go into the 1.4.1 final release?

1.4.1 is a bug fix release so doesn't include any new functionality ... 
unless you can convince Conor it is absolutely vital or something ;)


-- 
Cheers,

Pete

------------------------------
Kitsch never goes out of style
------------------------------