ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Brittain <jas...@collab.net>
Subject Re: [PATCH] Path.java does not support inclusion of directories
Date Thu, 11 Oct 2001 17:17:24 GMT

Peter Donald wrote:

>
> The problem is that this is not backwards compatible and would break 
> virtually every build file I use 


Sounds to me like that's a problem with the way you
are writing your build files.

> so it will never make it in as is. 


So because you are writing build files that break due to this
bug you're not going to allow the bug to be fixed in the right
way?  Uhh..

> You may 
> be able to add an extra attribute includedirs that defaults to false though. 


People do expect Path to include directories when their filesets
do.  I've even found other people who have seen the same problem
because they expect that behavior.

The default should be that Paths include dirs when the filesets
do, not "false".

Anyone else out there agree?


>>Can this patch go into the 1.4.1 final release?
> 
> 1.4.1 is a bug fix release so doesn't include any new functionality ... 


That is exactly why I'm asking to include this bug fix in the
1.4.1 release.  It is not new functionality.  It's a bug fix.


> unless you can convince Conor it is absolutely vital or something ;)


While it isn't vital that it go into 1.4.1, I do feel that it
should go in, and soon because this does fix a problem that
people are having with Ant.

-- 
Jason Brittain
<jasonb(at)collab(dot)net>
CollabNet http://www.collab.net


Mime
View raw message