ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Magesh Umasankar" <umag...@rediffmail.com>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional PropertyFile.java
Date Tue, 23 Oct 2001 14:19:39 GMT

Good catch, Conor!  This patch should take care of it.

Thanks,
Magesh

On Tue, 23 Oct 2001 Conor MacNeill wrote :
> bodewig@apache.org wrote:
> 
> > bodewig     01/10/23 04:49:45
> > 
> >   Modified:    .        WHATSNEW
> >                src/main/org/apache/tools/ant/taskdefs/-
> optional
> >                         PropertyFile.java
> >   Log:
> >   make sure <propertyfile> closes the file it's been 
> reading from.
> >   
> >   Submitted by:	Magesh Umasankar 
> <umagesh@rediffmail.com>
> >   
> 
> Shouldn't this use the try-finally construction we use 
> elsewhere to 
> guarantee file closing in the face of exceptions?
> 
> Conor
> 
 

Mime
View raw message