ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: [PATCH] Path.java does not support inclusion of directories
Date Thu, 11 Oct 2001 10:08:08 GMT
On Thu, 11 Oct 2001 04:51, Jason Brittain wrote:
>    <path id="foo">
>      <fileset dir="/tmp/bar" includes="*"/>
>    </path>
>
> and in the dir /tmp/bar is
>
> /tmp/bar/
>           dir1/
>           dir2/
>           file1.ext
>
> Before the patch, the contents of the path (on UNIX) would look like this:
>
> "/tmp/bar/file1.ext"
>
> Note the missing dir1 and dir2 paths that are supposed to be in there.
> After the patch the contents of the path (on UNIX) would correctly be:
>
> "/tmp/bar/file1.ext:/tmp/bar/dir1:/tmp/bar/dir2"

The problem is that this is not backwards compatible and would break 
virtually every build file I use so it will never make it in as is. You may 
be able to add an extra attribute includedirs that defaults to false though. 
Not sure - anyone else got any better ideas ?


> Can this patch go into the 1.4.1 final release?

1.4.1 is a bug fix release so doesn't include any new functionality ... 
unless you can convince Conor it is absolutely vital or something ;)


-- 
Cheers,

Pete

------------------------------
Kitsch never goes out of style
------------------------------

Mime
View raw message