ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthew Inger <ma...@sedonacorp.com>
Subject Re: [PATCH] new optional ReplaceRegExp task
Date Fri, 26 Oct 2001 13:23:09 GMT
I am willing to help with what i can.


On Fri, 2001-10-26 at 06:05, Stefan Bodewig wrote:
> The last ant-dev mail I have received has been sent Tue, 23 Oct 2001
> 13:36:55 -0500 (which is around 40 hours ago) - since I'm subscribed
> with my apache.org address, which in turn will forward it elsewhere,
> I suffer from the Apache mail problems with double impact ...
> 
> If you want to reach me faster, use my work address <bodewig@bost.de>.
> 
> I've committed a major improvement of yesterday's regexp stuff.
> 
> On 25 Oct 2001, Stefan Bodewig <bodewig@apache.org> wrote:
> 
> > TODO:
> >
> > * Adding testcases for the various match options
> > 
> > * Adding testcases for the substitution stuff
> > 
> > * Unify substitution syntax to use \1 for references, no matter
> >   which regexp implementation is used
> > 
> > * Make the task actually work
> 
> Done.
> 
> Deciding to use \1 in the substitutions is a bit arbitrary, as ORO
> uses $1, while JDK 1.4 uses $(1) and Jakarta Regexp's RE.subst method
> doesn't support them at all - but the task now works for all three
> implementations.  I used the \1 form as this is what the <mapper>
> currently uses as well.
> 
> > * Documentation for the task in Ant's normal HTML form.
> 
> Still to do and important.
> 
> > * Deciding whether we really want <replaceregexp>,
> >   <regularexpression> and <substitution> or can come up with
> >   something shorter than those.
> 
> still open.
> 
> > * Provide a wrapper for classes that only implement the Matcher
> >   interface by stealing code from
> >   RegexpPatternMapper.replaceReferences
> 
> I've started to do that and came across some shortcomings of our
> current regexp interfaces - we don't support repeated matching and
> don't provide access to start/end indices of matches.  Therefore the
> wrapper's substitute method doesn't work, this will be fixed after a
> bit contemplating over the RegexpMatcher interface.
> 
> > * Make the regexp mapper use the new Regexp interface
> > 
> > * (later) migrate all tasks that use ORO to the new Regexp classes
> 
> This is a bit of a lower priority to me, as I want to get the
> framework right first.  I also want to look into all the other regexp
> replace tasks that have been contributed (Matthew has not been the
> only one 8-) to see whether we should merge in some ideas of the other
> tasks.
> 
> Stefan
-- 
Matt Inger (matt.inger@sedonacorp.com)
Sedona Corporation
455 S. Gulph Road, Suite 300
King of Prussia, PA 19406
(484) 679-2213
"Self-respect - the secure feeling that no one,
 as yet, is suspicious." -H.L. Mencken 


Mime
View raw message