Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
Content-Type: text/plain;
  charset="iso-8859-1"
From: Peter Donald <donaldp@apache.org>
To: ant-dev@jakarta.apache.org
Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant
 ProjectHelper.java Target.java
Date: Thu, 27 Sep 2001 21:26:03 +1000
References: <20010927112724.74117.qmail@icarus.apache.org>
In-Reply-To: <20010927112724.74117.qmail@icarus.apache.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20010927113229.CXAY13193.mss.rdc2.nsw.optushome.com.au@there>

On Thu, 27 Sep 2001 21:27, bodewig@apache.org wrote:
>   1.22.2.1  +4 -1     
> jakarta-ant/src/main/org/apache/tools/ant/Target.java
>
>   Index: Target.java
>   ===================================================================
>   RCS file:
> /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/Target.java,v
> retrieving revision 1.22
>   retrieving revision 1.22.2.1
>   diff -u -r1.22 -r1.22.2.1
>   --- Target.java	2001/08/02 11:42:55	1.22
>   +++ Target.java	2001/09/27 11:27:24	1.22.2.1
>   @@ -85,7 +85,10 @@
>                StringTokenizer tok =
>                    new StringTokenizer(depS, ",", false);
>                while (tok.hasMoreTokens()) {
>   -                addDependency(tok.nextToken().trim());
>   +                String token = tok.nextToken().trim();
>   +                if (!token.equals("")) {
>   +                    addDependency(token);
>   +                }
>                }

Are you sure this is a good idea? This allows dependencies such as "a," to be 
classified as valid which definetly is not the behaviour I would expect.

-- 
Cheers,

Pete

------------------------------------------------
 "No. Try not. Do. Or do not. There is no try." 
                                     -- Yoda 
------------------------------------------------