Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
Content-Type: text/plain;
  charset="iso-8859-1"
From: Peter Donald <donaldp@apache.org>
Reply-To: donaldp@apache.org
To: ant-dev@jakarta.apache.org
Subject: Re: [PATCH] Ant pvcs task & Bug 3219
Date: Thu, 6 Sep 2001 12:49:18 +1000
References: <E12AAA650173D4119FF400805FE606190E3E1DCF@exchange1.standard.com>
 <00ca01c1367e$492475f0$291e020a@note205>
In-Reply-To: <00ca01c1367e$492475f0$291e020a@note205>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20010906025655.FXLE4715.mss.rdc2.nsw.optushome.com.au@there>

oops - I just committed last patch ;/

I have no idea on PVCS so if someone who knows more could check out your 
patch ?

On Thu, 6 Sep 2001 12:47, sp-ota wrote:
> I also sent a patch to the list available from the following link.
>
> http://www.mail-archive.com/ant-dev@jakarta.apache.org/msg09475.html
>
> I believe this patch is better because it eliminates I/O and avoid
> unnecessary filtering.
>
> As a matter of fact, I've been very wondering why the previous author and
> every patch sender
> like to do "massagePCLI" and to check the filename on returned file list
> from PCLI.
>
> Why does "massagePCLI" necessary?
> It returns appropreate filenames, so that I don't think filtering is
> necessary.
>
> Also, I can not understand why "createFolders" checks the format of
> filename.
> PCLI returns non-zero code if terminated with an error.
> Otherwise, it returns a file list.
> Therefore, if PCLI does not fail, the format of a file list should be
> correct and
> I think filtering is not necessary.
> If PCLI fails, Ant stops build task.
>
> Do you have any idea?

-- 
Cheers,

Pete

*------------------------------------------------------*
|  Hlade's Law: If you have a difficult task, give it  |
|     to a lazy person -- they will find an easier     |
|                    way to do it.                     |
*------------------------------------------------------*