Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
Message-ID: <002201c1373d$0df81760$291e020a@note205>
From: "sp-ota" <ota.yoshihiro@future.co.jp>
To: <ant-dev@jakarta.apache.org>
References: <E12AAA650173D4119FF400805FE606190E3E1DD9@exchange1.standard.com>
Subject: Re: [PATCH] Ant pvcs task & Bug 3219
Date: Fri, 7 Sep 2001 10:33:10 +0900
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit


----- Original Message -----
From: "Steven Newton" <snewton@standard.com>
To: <ant-dev@jakarta.apache.org>
Sent: Friday, September 07, 2001 12:20 AM
Subject: RE: [PATCH] Ant pvcs task & Bug 3219


>
>
> > -----Original Message-----
> > From: Peter Donald [mailto:donaldp@apache.org]
> >
> > oops - I just committed last patch ;/
> >
> > I have no idea on PVCS so if someone who knows more could
> > check out your
> > patch ?
> >
> > On Thu, 6 Sep 2001 12:47, sp-ota wrote:
> > > I also sent a patch to the list available from the following link.
> > >
> > > http://www.mail-archive.com/ant-dev@jakarta.apache.org/msg09475.html
> > >
> > > Why does "massagePCLI" necessary?
> > > It returns appropreate filenames, so that I don't think filtering is
> > > necessary.
> > >
>
> This is a cross-platform issue.  If the path separator is "\" it
> will work fine on DOS-ish systems but Unix will be very unhappy.
>
> Ditto for pathnames starting with "\\", being an SMB share
> convention, this wouldn't work under Unix.
>
> I like the idea of using a Hashtable to reduce the number of
> mkdir calls.
>
> s

Well, I see.
I did not have UNIX platform and couldn't test.
As far as I read the manual downloaded from Merant web site, it seems
that PCLI on UNIX returns a file list in UNIX path style, such as
/your/path.
So, I guess this filtering is required when accessing to a repository on
another platform.
Is this correct?

I will lose this e-mail account and have to be out of this mailing list in 5
days or so.
I guess you can include Hashtable to PVCS task.

This is some note for you.
I'm not sure how much these will improve performance, though.

1.
File.mkdirs() calls File.exists(); you don't have to call File.exists().

2.
new File("path").getParent() has more overhead than
"path".substring("path".lastIndexOf(File.separator)).

new File("path") verifies if "path" is formatted correct.
PCLI returns a path which is correctly formatted.
So, only String manipulation is enough.