ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Donald <dona...@apache.org>
Subject Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs GZip.java
Date Mon, 17 Sep 2001 04:59:34 GMT
On Mon, 17 Sep 2001 11:08, Conor MacNeill wrote:
> > From: Peter Donald [mailto:donaldp@apache.org]
> >
> > Consider this the last ditch effort ;)
>
> OK, here is my last ditch response :-)

;P~

> > I think it makes more sense for the source file to be designated
> > with file=""
> > attribute because that follows convention of rest of ant tasks. Any
> > objections to that?
>
> Well, it is only really true of the <copy> and <move> tasks. There are
> other tasks where this is not true. It is not true of the recent changes
> you made to Zip.java and its decendants, nor is it true for a task such as
> <echo>. So I don't really agree that this is a convention. It will also be
> very difficult to institute this convention in a backward compatible way
> since it reverses the meaning of existing attributes.

okay you convinced me ;) Will revert ;)

> I like conventions but I think we need to be careful about over
> abstraction. I like to think of the java task dealing with source. IOW, I
> think of compiling the source - not compiling a directory - if you know
> what I mean. I'm not convinced there is a benefit is making all tasks fit
> this
> "interface"

kool. Maybe this can be handballed to Ant2 again ;)

-- 
Cheers,

Pete

-----------------------------------------------------------
    If your life passes before your eyes when you die, 
 does that include the part where your life passes before 
                        your eyes?
-----------------------------------------------------------


Mime
View raw message