ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sp-ota" <ota.yoshih...@future.co.jp>
Subject Re: [PATCH] Ant pvcs task & Bug 3219
Date Thu, 06 Sep 2001 02:47:35 GMT
I also sent a patch to the list available from the following link.

http://www.mail-archive.com/ant-dev@jakarta.apache.org/msg09475.html

I believe this patch is better because it eliminates I/O and avoid
unnecessary filtering.

As a matter of fact, I've been very wondering why the previous author and
every patch sender
like to do "massagePCLI" and to check the filename on returned file list
from PCLI.

Why does "massagePCLI" necessary?
It returns appropreate filenames, so that I don't think filtering is
necessary.

Also, I can not understand why "createFolders" checks the format of
filename.
PCLI returns non-zero code if terminated with an error.
Otherwise, it returns a file list.
Therefore, if PCLI does not fail, the format of a file list should be
correct and
I think filtering is not necessary.
If PCLI fails, Ant stops build task.

Do you have any idea?

----- Original Message -----
From: "Steven Newton" <snewton@standard.com>
To: <ant-dev@jakarta.apache.org>
Sent: Thursday, September 06, 2001 6:44 AM
Subject: [PATCH] Ant pvcs task & Bug 3219


> Hello,
>
> I have used the pvcs task and have come up with a patch that
> I believe will address Bug ID 3219 in a slightly more flexible
> way, and also allows the archive filename extension to vary
> from the format hardcoded in the createFolders() method in
> Pvcs.java



Mime
View raw message