Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
Message-ID: <3B6C080E.3070703@powerup.com.au>
Date: Sun, 05 Aug 2001 00:34:54 +1000
From: "Peter B. West" <pbwest@powerup.com.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.2+) Gecko/20010801
MIME-Version: 1.0
To: ant-dev@jakarta.apache.org
Subject: Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs
 FixCRLF.java
References: <20010803161516.63041.qmail@icarus.apache.org>
 <m3vgk5cdud.fsf@bodewig.bost.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Stefan,

You and me both.  When I made the changes to accommodate the large 
files, I forgot to tests change-in-place.  Pretty disgraceful.  Mea culpa.

I have modified the code I found in the repository, which did not 
compile for me.  As a penance, I have included code to restore the 
functionality to write the file only when the destination file changes.

I have performed a variety of tests on this (including change-in-place), 
but this has been done in a hurry, and I do not yet have a neat set of 
test cases.  Let me know if you want some.  The code for the new 
functionality includes a handful of println's for the basic temp file 
test conditions, which you will no doubt want to remove.  I have used 
the method that Conor (I think) added to create the temp file, and I 
have added a method to check for file equality.

I will now go back to providing a minimum set of changes to the HTML, as 
requested.

Peter

Stefan Bodewig wrote:
> should have run this task on the source file before committing, hmm.
> 
> Stefan
> 
> 


-- 
Peter B. West  pbwest@powerup.com.au  http://powerup.com.au/~pbwest
"Lord, to whom shall we go?"