ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@cortexebusiness.com.au>
Subject RE: [PATCH] Log4jListener typo
Date Mon, 13 Aug 2001 00:20:58 GMT
> From: Erik Hatcher [mailto:erikhatcher@earthlink.net]
>
> I was just browsing around the Ant source code becoming more familiar with
> its architecture and happened to be looking at the Log4jListener code and
> saw what I think is a typo.   Target.class.getName() is used in
> buildFinished, when I'm almost certain it should use
> Project.class.getName()
> like buildStarted uses.
>
> Here's the patch if I'm indeed correct.

You are - thanks.

>
> Also, a question about this listener: Would it make sense in
> targetStarted/Finished (and likewise in the messageLogged method) to use a
> category name based on the actual targets name attribute rather than just
> the classname for the Task class?   I'm not sure what use this
> would be, but
> would it add any flexibility or just make things more confusing and harder
> to configure?

Don't know the answer to that. I haven't used Log4J much but I have always
used the class of the object as the category. Much of a muchness.

Conor




Mime
View raw message