ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [DO NOT REPLY: Bug 3271] Jar task ignores first line of manifest
Date Sat, 25 Aug 2001 11:59:13 GMT
PLEASE DO NOT REPLY TO THIS MESSAGE. TO FURTHER COMMENT
ON THE STATUS OF THIS BUG PLEASE FOLLOW THE LINK BELOW
AND USE THE ON-LINE APPLICATION. REPLYING TO THIS MESSAGE
DOES NOT UPDATE THE DATABASE, AND SO YOUR COMMENT WILL
BE LOST SOMEWHERE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3271

*** shadow/3271	Sat Aug 25 02:53:56 2001
--- shadow/3271.tmp.29636	Sat Aug 25 04:59:13 2001
***************
*** 2,9 ****
  | Jar task ignores first line of manifest                                    |
  +----------------------------------------------------------------------------+
  |        Bug #: 3271                        Product: Ant                     |
! |       Status: NEW                         Version: 1.4Beta2                |
! |   Resolution:                            Platform: All                     |
  |     Severity: Normal                   OS/Version: All                     |
  |     Priority: Other                     Component: Core tasks              |
  +----------------------------------------------------------------------------+
--- 2,9 ----
  | Jar task ignores first line of manifest                                    |
  +----------------------------------------------------------------------------+
  |        Bug #: 3271                        Product: Ant                     |
! |       Status: RESOLVED                    Version: 1.4Beta2                |
! |   Resolution: FIXED                      Platform: All                     |
  |     Severity: Normal                   OS/Version: All                     |
  |     Priority: Other                     Component: Core tasks              |
  +----------------------------------------------------------------------------+
***************
*** 14,17 ****
  |          URL:                                                              |
  +============================================================================+
  |                              DESCRIPTION                                   |
! I passed the Jar task a manifest file consisting of a single line specifying the "Main-Class"
attribute, but the manifest that was written to the jar file was merely Ant's default manifest,
with its "Manifest-Version" and "Created-By" attributes.  There were no error messages; it
just seemed to ignore my manifest file.  The problem is that the constructor for the Manifest
class starts out by reading the first line of the manifest file, but never does anything with
it.  This is okay if the first line contains the "Manifest-Version" attribute, since the class
supplies a default value to replace the dropped line.  But I can't believe this is the intended
behavior; the "Manifest-Version" attribute has to be in the first line if it's present at
all, but it is NOT required.
--- 14,26 ----
  |          URL:                                                              |
  +============================================================================+
  |                              DESCRIPTION                                   |
! I passed the Jar task a manifest file consisting of a single line specifying the "Main-Class"
attribute, but the manifest that was written to the jar file was merely Ant's default manifest,
with its "Manifest-Version" and "Created-By" attributes.  There were no error messages; it
just seemed to ignore my manifest file.  The problem is that the constructor for the Manifest
class starts out by reading the first line of the manifest file, but never does anything with
it.  This is okay if the first line contains the "Manifest-Version" attribute, since the class
supplies a default value to replace the dropped line.  But I can't believe this is the intended
behavior; the "Manifest-Version" attribute has to be in the first line if it's present at
all, but it is NOT required.
! 
! ------- Additional Comments From conor@cortexebusiness.com.au  2001-08-25 04:59 -------
! It was a bug - I fixed it. However, I should point out that according to the 
! BNF in http://java.sun.com/j2se/1.3/docs/guide/jar/jar.html#JAR%20Manifest
! the Manifest-Version attribute IS required, certainly in the manifest file in 
! the jar. Both the jar command and the <jar> task should and do handle 
! situations when it is not.
! 
! Thanks - will be in the final version of 1.4

Mime
View raw message