ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <erikhatc...@earthlink.net>
Subject [PATCH] Log4jListener typo
Date Sun, 12 Aug 2001 00:46:11 GMT
I was just browsing around the Ant source code becoming more familiar with
its architecture and happened to be looking at the Log4jListener code and
saw what I think is a typo.   Target.class.getName() is used in
buildFinished, when I'm almost certain it should use Project.class.getName()
like buildStarted uses.

Here's the patch if I'm indeed correct.

Also, a question about this listener: Would it make sense in
targetStarted/Finished (and likewise in the messageLogged method) to use a
category name based on the actual targets name attribute rather than just
the classname for the Task class?   I'm not sure what use this would be, but
would it add any flexibility or just make things more confusing and harder
to configure?

Thanks,
    Erik


Index: Log4jListener.java
===================================================================
RCS file:
/home/cvspublic/jakarta-ant/src/main/org/apache/tools/ant/listener/Log4jList
ener.java,v
retrieving revision 1.1
diff -u -r1.1 Log4jListener.java
--- Log4jListener.java 2001/08/03 14:21:00 1.1
+++ Log4jListener.java 2001/08/12 00:31:13
@@ -90,7 +90,7 @@

     public void buildFinished(BuildEvent event) {
         if (initialized) {
-            Category cat = Category.getInstance(Target.class.getName());
+            Category cat = Category.getInstance(Project.class.getName());
             if (event.getException() == null) {
                 cat.info("Build finished.");
             }






Mime
View raw message