Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
Message-ID: <000201c1085f$a56d8ce0$b4c4223f@cognetnt>
From: "Conor MacNeill" <conor@cortexebusiness.com.au>
To: <ant-dev@jakarta.apache.org>
References: <37B2E6BFD50BD411970000B0D021D9C032393C@intranet.tel.cril.net>
Subject: Re: [PATCH] BorlandDeploymentTool task
Date: Mon, 9 Jul 2001 19:13:48 +1000
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

Patch stated that the patch was incomplete. No other warnings. (Cygwin
version of patch). If the code is OK, then no problems. As for imports, it
is the same at my company but there was a discussion on this list a long
time ago that it was good to use star imports.

Conor


----- Original Message -----
From: "MOUSSAUD Beno�t" <benoit.moussaud@criltelecom.com>
To: <ant-dev@jakarta.apache.org>
Sent: Monday, July 09, 2001 6:03 PM
Subject: RE: [PATCH] BorlandDeploymentTool task


can you give me the warning list ?

ok for the imports ! In my company, we prefere not to have star imports !

Benoit

--------------------------------------------
Benoit Moussaud - Software Team Leader
benoit.moussaud@criltelecom.com
CTS - Cril Telecom Software
http://www.criltelecom.com
8 rue danjou
92517 Boulogne Billancourt - France
Tel: (33) 1 58 17 04 78


-----Message d'origine-----
De : Conor MacNeill [mailto:conor@cortexebusiness.com.au]
Envoy� : samedi 7 juillet 2001 15:05
� : ant-dev@jakarta.apache.org
Objet : Re: [PATCH] BorlandDeploymentTool task


Beno�t,

From: "MOUSSAUD Beno�t" <benoit.moussaud@criltelecom.com>
>

I have committed this. Can you check it since patch gave me some warnings.

> I have made some corrections on BorlandDeploymentTool task.
> * import cleaning

The Jakarta project tends to use * style imports - so I changed this.

Conor