ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [GUMP] Build Failure - batik
Date Mon, 16 Jul 2001 06:09:39 GMT
On Sat, 14 Jul 2001, Sam Ruby <rubys@us.ibm.com> wrote:

> See http://jakarta.apache.org/builds/gump/2001-07-14/xml-batik.html
> for details.
> 
> Question for ant-dev:
> 
>    Should <exclude name="**/jpython*" unless="jpython.present"/>
>    match org/apache/batik/script/jpython/JPythonInterpreter.java?

This is due to a change I've put into DirectoryScanner last Friday -
The pattern matches the directory jpython and so Ant assumed this
directory could not hold any included files and skipped the directory
for Ant 1.2 and 1.3.

There has been a bug report that convinced me that this assumption was
wrong - files under jpython should only be excluded if there is a
pattern that matches them IMHO, so I think the current behavior is
correct (and is the same Ant 1.1 showed BTW).

The problem now is that the pattern matching algorithm doesn't think
the * in jpython* could match a / (we use ** for matches that can
contain an arbitrary number of slashes and * for no slashes at all).
To me this looks consistent and I'd add in a slash to the pattern
which should not only fix this problem but also make the intent
clearer.

I am willing to modify the pattern matching part if others feel my
interpretation is wrong 8-)

Stefan

Mime
View raw message