ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry V. Streepy, Jr." <stre...@healthlanguage.com>
Subject Re: [Bug 1380] - I think that having conditional fails make more robust build files.
Date Fri, 06 Jul 2001 14:46:04 GMT
It may be too late to lobby for this change (i tried once already :-).

When I first learned ant, it took me a while to figure out how to ensure
that certain properties where set at entry to the build.  In order to do
this I had to use an idiom that required writing a target for every
property I wanted to test.  As the number of properties grew, I found
that the build file became bloated with loads of "extra" targets.

Also, the cases where I wanted to fail the build, unconditionally, was
very tiny, like zero. :-)

IMO, it is dramatically simpler to allow the fail task to have an
if/unless (as do patternsets) since it allows me to place all my
property checking into a single target.  It makes the build file more
understandable, thus more maintainable by the unfortunate person that
will inherit the build after I'm through with it.

Ok, I'm done lobbying.  Thanks for listening.


Glenn McAllister wrote:
> 
> "Larry V. Streepy, Jr." wrote:
> 
> > Ok, I must have taken stupid pills this morning because I can't figure
> > out what just happened with this bug.
> >
> > I see that the status changed to RESOLVED, but the comments don't
> > indicate what happened.
> 
> But the bug report does.  The Resolution has been changed to REMIND.  I agreed that
> there was a pretty good use case, but that I didn't want to start introducing if/unless
> at the task level for Ant1.  Thus, I set the resolution to REMIND so we can revisit
> this issue for Ant 2 but get it off the books for Ant 1 so we can drive towards a 1.4
> release.
> 
> > >
> > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=1380
> > >
> > > *** shadow/1380 Thu Jun 21 07:25:54 2001
> > > --- shadow/1380.tmp.24500       Wed Jul  4 13:29:28 2001
> > > ***************
> > > *** 2,11 ****
> > >   | I think that having conditional fails make  more robust build files.  
    |
> > >   +----------------------------------------------------------------------------+
> > >   |        Bug #: 1380                        Product: Ant                
    |
> > > ! |       Status: NEW                         Version: 1.3                
    |
> > > ! |   Resolution:                            Platform: All                
    |
> > >   |     Severity: Enhancement              OS/Version: All                
    |
> > > ! |     Priority:                           Component: Core tasks         
    |
> > >   +----------------------------------------------------------------------------+
> > >   |  Assigned To: ant-dev@jakarta.apache.org                              
    |
> > >   |  Reported By: gholam@xtra.co.nz                                       
    |
> > > --- 2,11 ----
> > >   | I think that having conditional fails make  more robust build files.  
    |
> > >   +----------------------------------------------------------------------------+
> > >   |        Bug #: 1380                        Product: Ant                
    |
> > > ! |       Status: RESOLVED                    Version: 1.3                
    |
> > > ! |   Resolution: REMIND                     Platform: All                
    |
> > >   |     Severity: Enhancement              OS/Version: All                
    |
> > > ! |     Priority: High                      Component: Core tasks         
    |
> > >   +----------------------------------------------------------------------------+
> 
> Glenn McAllister
> SOMA Networks, Inc.

-- 
Larry V. Streepy, Jr.
Chief Technical Officer and VP of Engineering

Health Language, Inc.  -- "We speak the language of healthcare"

970/626-5028 (office)           mailto:streepy@healthlanguage.com
970/626-4425 (fax)              http://www.healthlanguage.com

Mime
View raw message