ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@cortexebusiness.com.au>
Subject Re: Private/protected
Date Sat, 28 Jul 2001 14:43:39 GMT
From: <cmanolache@yahoo.com>
To: <ant-dev@jakarta.apache.org>
Sent: Saturday, July 28, 2001 3:10 AM
Subject: Private/protected


> Hi,
>
> Would it be possible to change few of the fields in Project from private
> to protected ?

-1

>
> I'm interested in properties, user properties, references. I don't think
> that would hurt any existing functionality.

True, but it increases the exposure of the internal implementation to code
outside the Ant project. For backward compatability reasons, this will make
it harder to change the implementation of Project. For example, in future,
all properties could be gather together into some other structure. Backward
compatability is a big enough bind as it is already.

If you need access to these, then please use the existing methods where
possible and defined new methods to manipulate these fields if needed.

>
> Right now there are a number of protected methods ( except
> fireMessageLoggedEvent - is there any reason for having it private while
> all others fireXXX are not ? ).
>
> I assume ( from having protected methods ) that it is allowed to extend
> Project.

You are not the first to try this :-) You may want to address this bug
while you are at it :-)
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2652

>
> What I'm doing is use ant  "embeded" in a web page. What I want is to
make
> the properties ( and/or refs ) available to non-ant code, using
> context/session or page attributes. In order to do so I want to replace
> the Hashtables with a wrapper ( some class extending Hashtable that
> delegates to the desired repository ).
>
>

Not sure what this other class is. Why not just load the properties from
the repository ?

Conor





Mime
View raw message