Patch stated that the patch was incomplete. No other warnings. (Cygwin
version of patch). If the code is OK, then no problems. As for imports, it
is the same at my company but there was a discussion on this list a long
time ago that it was good to use star imports.
Conor
----- Original Message -----
From: "MOUSSAUD Benoît" <benoit.moussaud@criltelecom.com>
To: <ant-dev@jakarta.apache.org>
Sent: Monday, July 09, 2001 6:03 PM
Subject: RE: [PATCH] BorlandDeploymentTool task
can you give me the warning list ?
ok for the imports ! In my company, we prefere not to have star imports !
Benoit
--------------------------------------------
Benoit Moussaud - Software Team Leader
benoit.moussaud@criltelecom.com
CTS - Cril Telecom Software
http://www.criltelecom.com
8 rue danjou
92517 Boulogne Billancourt - France
Tel: (33) 1 58 17 04 78
-----Message d'origine-----
De : Conor MacNeill [mailto:conor@cortexebusiness.com.au]
Envoyé : samedi 7 juillet 2001 15:05
À : ant-dev@jakarta.apache.org
Objet : Re: [PATCH] BorlandDeploymentTool task
Benoît,
From: "MOUSSAUD Benoît" <benoit.moussaud@criltelecom.com>
>
I have committed this. Can you check it since patch gave me some warnings.
> I have made some corrections on BorlandDeploymentTool task.
> * import cleaning
The Jakarta project tends to use * style imports - so I changed this.
Conor
|