Return-Path: 
 <ant-dev-return-14746-apmail-jakarta-ant-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-ant-dev-archive@jakarta.apache.org
Received: (qmail 25249 invoked by uid 500); 13 Jun 2001 07:56:01 -0000
Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ant-dev@jakarta.apache.org
list-help: <mailto:ant-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:ant-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:ant-dev@jakarta.apache.org>
Delivered-To: mailing list ant-dev@jakarta.apache.org
Received: (qmail 25060 invoked from network); 13 Jun 2001 07:56:00 -0000
Message-ID: <4E7888D4F219E145B6F81E5D3049E3BF1B10AB@scmail01.arsin.com>
From: Peter  Vogel <pvogel@arsin.com>
To: "'ant-dev@jakarta.apache.org'" <ant-dev@jakarta.apache.org>,
	"'bodewig@apache.org'" <bodewig@apache.org>
Subject: RE: [PATCH]tarfileset
Date: Wed, 13 Jun 2001 00:56:06 -0700
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

I just snagged the latest from Apache, looks like someone already
took care of it...

                for (int i = 0; i < files.length; i++) {
                    File f = new File(fs.getDir(project), files[i]);
                    String name = files[i].replace(File.separatorChar,'/');
                    tarFile(f, tOut, name, fs);
                }

Since it is now correctly using fs.getDir(project) instead of the 
baseDir it was using!


-Peter

> -----Original Message-----
> From: Peter Vogel [mailto:pvogel@arsin.com]
> Sent: Wednesday, June 13, 2001 12:33 AM
> To: 'ant-dev@jakarta.apache.org'; 'bodewig@apache.org'
> Subject: [PATCH]tarfileset
> 
> 
> Per the discussion earlier today, there's a bug in 
> <tarfileset>, if the
> <tar> tag has a <baseDir>
> attribute and <tarfileset>s are used as well, the baseDir 
> causes an implicit
> fileset and
> if the <tarfileset>s overlap the baseDir you get two of every file.
> 
> On the other hand, if the baseDir isn't set and you use 
> <tarfileset>s, the
> dir attribute for the 
> tarfileset doesn't seem to be obeyed and tar is unable to 
> find any files!
> 
> This patch is probably incomplete, in particular, the 
> archiveIsUpToDate
> routine is calling a
> SouceFileScanner and doesn't seem to setting up the directory 
> right (it
> passes baseDir in
> blindly as the srcDir) so you get messages like this in verbose mode:
> 
>       [tar] ws\html\html\passwd.html added as
> C:\e2open\b1003_patch1\sso\grass.tar doesn't exist.
> 
> But at least with this patch I get what I expect out of my 
> tar files build
> using a <tar> with <tarfileset>
> embedded tags...
> 
> -Peter
>  <<tarfilesetpatch.txt>> 
>