ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher" <erikhatc...@earthlink.net>
Subject Re: [PATCH] JUnitTask.java / XMLJUnitResultFormatter.java
Date Mon, 18 Jun 2001 23:11:12 GMT
I've made the changes to JUnitTestRunner.java, JUnitTask.java, and
JUnitTest.java to handle forked <junit> tests.

I've attached a file with the CVS diff's (again, let me know if this is not
a usable format).  Also, I've added myself as an author tag on a few of the
files (all but one, where I only modified a few lines of code).   I'm not
sure what the rules are with that, but if I'm under the number of lines of
code to deserve that tag, my feelings won't be hurt if you take it off!  :)

    Erik


----- Original Message -----
From: "Stephane Bailliez" <sbailliez@imediation.com>
To: <ant-dev@jakarta.apache.org>
Sent: Friday, June 15, 2001 8:33 AM
Subject: RE: [PATCH] JUnitTask.java / XMLJUnitResultFormatter.java


I would go for this solution. (don't forget not to use File.createTmpFile
it's JDK1.2+)

--
 St├ęphane Bailliez
 Software Engineer, Paris - France
 iMediation - http://www.imediation.com
 Disclaimer: All the opinions expressed above are mine and not those from my
company.



> -----Original Message-----
> From: Erik Hatcher [mailto:erikhatcher@earthlink.net]
> Sent: Friday, June 15, 2001 5:20 PM
> To: ant-dev@jakarta.apache.org
> Subject: Re: [PATCH] JUnitTask.java / XMLJUnitResultFormatter.java
>
>
> While writing my article, I came across an issue with my
> modifications that
> I wanted to note.   The additional properties are not
> captured if the JUnit
> task is forked into a separate JVM (<junit fork="yes">)
> because of the way
> the JUnitTest is executed from the JUnitTestRunner in this
> case (there is no
> Project available in which to grab properties from).
>
> I will work on a solution that will still capture at least the System
> properties (in main of JUnitTestRunner), but probably also get the
> properties from the Project passed to the spawned process.
> Does anyone
> have any suggestions on how to go about doing this?   A hack
> that would work
> would be to create a temporary properties file and pass its
> filename to the
> command-line execution of JUnitTestRunner, and then overlay the System
> properties on top of the passed-in Project properties.   Is
> there a more
> elegant way to do this?
>
> I apologize for not catching this sooner, but I wasn't
> forking the <junit>
> task so this issue did not arise.
>
>     Erik
>
>
> ----- Original Message -----
> From: "Erik Hatcher" <erikhatcher@earthlink.net>
> To: "ant-dev" <ant-dev@jakarta.apache.org>
> Sent: Monday, June 11, 2001 8:24 AM
> Subject: [PATCH] JUnitTask.java / XMLJUnitResultFormatter.java /
> MimeMail.java
>
>
> > Attached are the code modifications I've made to the JUnit
> task in order
> to
> > get the Ant properties captured for each test suite run.
> >
> > I've never submitted a patch before, so let me know if the
> format of the
> two
> > attached files is acceptable or not.
> >
> > Note: The change to XMLJUnitResultFormatter.java was made to the 1.3
> release
> > version from CVS, but there has been one change made to it
> since then
> (this
> > should not be a factor when applying the patch, but I just
> wanted to note
> > it).
> >
> >     Erik
> >
> >
>

Mime
View raw message