Return-Path: Delivered-To: apmail-jakarta-ant-dev-archive@jakarta.apache.org Received: (qmail 45754 invoked by uid 500); 2 Apr 2001 06:52:42 -0000 Mailing-List: contact ant-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk Reply-To: ant-dev@jakarta.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list ant-dev@jakarta.apache.org Received: (qmail 45738 invoked from network); 2 Apr 2001 06:52:41 -0000 X-Authentication-Warning: bodewig.bost.de: bodewig set sender to bodewig@apache.org using -f To: ant-dev@jakarta.apache.org Subject: Re: [PATCH] ZipFileSet relative to project dir References: <379obt81cl9n535ijqdn9bpb8us2emhk0m@4ax.com> <935fctsslnsqmgbbpcdafci0o0538rcm3f@4ax.com> From: Stefan Bodewig Date: 02 Apr 2001 08:52:47 +0200 In-Reply-To: David Rees's message of "Sun, 01 Apr 2001 14:00:52 -0700" Message-ID: Lines: 31 User-Agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Cuyahoga Valley) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N David Rees wrote: > On 29 Mar 2001 12:24:29 +0200, Stefan Bodewig wrote: > >>David Rees wrote: >> >>> Fixes minor problem in ZipFileSet in so that it is relative to >>> project dir - not working dir >> >>does this have any effect? I mean, is the dir attribute used at all >>in this case? > > FileSet.setDir() actually tests the File so it does get accessed (if > not "used"). It used to, I moved the check - probably after you've submitted your patch - to the getDirectoryScanner method. > I came across it because in some rare cases VisualAge will run code > in a non-existent working directory. In these cases the tests will > fail because "." doesn't exist. Strange behavior. > However, the real reason I thought it was worth posting was that > directories should always be relative to the build file. Even if > directory is not being used for much (yet?). I'm going to buy this 8-) Stefan